Skip to content

cleanup: scorecard with its own test#3921

Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:test-e2e-scorcard
Oct 6, 2020
Merged

cleanup: scorecard with its own test#3921
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:test-e2e-scorcard

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Sep 19, 2020 •
edited
Loading

Description of the change:

  • only move the scorecard tests to e2e__scorecard_test

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 19, 2020
@camilamacedo86 camilamacedo86 added area/testing Issue related to testing the operator-sdk and subcomponents kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 19, 2020
@jberkhahn
Copy link
Copy Markdown
Contributor

jberkhahn commented Sep 24, 2020

seems fine
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 5, 2020
varshaprasad96
varshaprasad96 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@camilamacedo86 camilamacedo86 merged commit cf85c2d into operator-framework:master Oct 6, 2020
@camilamacedo86 camilamacedo86 deleted the test-e2e-scorcard branch October 6, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@estroz estroz Awaiting requested review from estroz

@jmrodri jmrodri Awaiting requested review from jmrodri

@joelanford joelanford Awaiting requested review from joelanford

@bharathi-tenneti bharathi-tenneti Awaiting requested review from bharathi-tenneti

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees

@jberkhahn jberkhahn

@varshaprasad96 varshaprasad96

Labels

area/testing Issue related to testing the operator-sdk and subcomponents kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamacedo86 @jberkhahn @varshaprasad96 @openshift-ci-robot