Skip to content

ansible-operator,helm-operator: improve executable help text#4187

Merged
estroz merged 5 commits intooperator-framework:masterfrom
jberkhahn:exec_warnings
Nov 6, 2020
Merged

ansible-operator,helm-operator: improve executable help text#4187
estroz merged 5 commits intooperator-framework:masterfrom
jberkhahn:exec_warnings

Conversation

@jberkhahn
Copy link
Copy Markdown
Contributor

Fixes #4106

@estroz

Comment thread cmd/ansible-operator/main.go Outdated
Comment thread cmd/helm-operator/main.go Outdated
jberkhahn and others added 2 commits November 5, 2020 11:15
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
@jberkhahn
Copy link
Copy Markdown
Contributor Author

@estroz updated

Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the fragment.
Otherwise, it shows ok for me 👍

@estroz
Copy link
Copy Markdown
Member

estroz commented Nov 5, 2020

@jberkhahn can you add a changelog fragment of kind: change that says something like

Improved ansible-operator and helm-operator binary help text

@jberkhahn
Copy link
Copy Markdown
Contributor Author

@estroz like this? never done one of these before, when should i and shouldn't i make one of these?

Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! thanks

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@estroz estroz changed the title add warning message to ansible-operator and helm-operator executables ansible-operator,helm-operator: improve executable help text Nov 6, 2020
@estroz estroz merged commit df23b7e into operator-framework:master Nov 6, 2020
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
…r-framework#4187)

Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify purpose of ansible-operator and helm-operator binaries

5 participants