change: (helm) - if the release is not installed but status.DeployedRelease is populated, skip the rollback(uninstall) if the install errors#4297
change: (helm) - if the release is not installed but status.DeployedRelease is populated, skip the rollback(uninstall) if the install errors#4297mikeshng wants to merge 1 commit intooperator-framework:masterfrom mikeshng:helm-installed-fix
Conversation
…elease is populated, skip the rollback(uninstall) if the install errors Signed-off-by: Mike Ng <ming@redhat.com>
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Mike Ng ming@redhat.com
Description of the change:
If all the Helm release records are deleted, then the Helm operator will try to install the release again. In that case, if the install errors, then don't perform the uninstall rollback because it might lead to unintended data loss.
Motivation for the change:
In some rare cases, the Helm operator is performing an unintended Helm uninstall which can cause data loss. This change is to ensure that the Helm uninstall doesn't happen in those cases.
Closes: #4296
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs