internal/plugins: add manifests and scorecard plugin keys to all projects#4419
Merged
estroz merged 2 commits intooperator-framework:masterfrom Feb 2, 2021
Merged
Conversation
estroz
force-pushed
the
chore/version-phase2-plugins
branch
from
0b5d3e1 to
36cc6f3
Compare
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Just a few nits to make the changelog follow up its convention/standard and make it more user friendly and comprehensive to the end-users. Otherwise, It shows great.
estroz
force-pushed
the
chore/version-phase2-plugins
branch
from
36cc6f3 to
8efd265
Compare
Member
Author
|
/assign @theishshah |
camilamacedo86
approved these changes
Jan 28, 2021
added 2 commits
February 2, 2021 11:53
to ansible/v1, helm/v1, and go/v2 projects on init, and consider these keys when running `create api` Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz
force-pushed
the
chore/version-phase2-plugins
branch
from
8efd265 to
22cd1d7
Compare
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…projects (operator-framework#4419) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…projects (operator-framework#4419) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…projects (operator-framework#4419) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…projects (operator-framework#4419) Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…projects (operator-framework#4419) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
waynesun09
added a commit
to waynesun09/reportportal-operator
that referenced
this pull request
Apr 21, 2021
Related to operator-sdk v1.4.0 upgrade: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.4.0/ operator-framework/operator-sdk#4419 Signed-off-by: Wayne Sun <gsun@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
manifestsandscorecardplugin keys to ansible/v1, helm/v1, and go/v2 projects on init, and consider these keys when runningcreate apiMotivation for the change: All phase 2 plugins should have keys in the
pluginsconfig field. This (backwards-compatible) change makes it so.Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs