generate: respect project version when getting package name#4431
Merged
estroz merged 2 commits intooperator-framework:masterfrom Jan 27, 2021
Merged
generate: respect project version when getting package name#4431estroz merged 2 commits intooperator-framework:masterfrom
estroz merged 2 commits intooperator-framework:masterfrom
Conversation
added 2 commits
January 25, 2021 13:06
…ing package name Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
d94456a to
fe0a598
Compare
Member
Author
|
/assign @rashmigottipati |
Member
Author
|
/cherry-pick v1.3.x |
|
@estroz: #4431 failed to apply on top of branch "v1.3.x": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Jan 27, 2021
estroz
pushed a commit
that referenced
this pull request
Jan 27, 2021
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…-framework#4431) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…-framework#4431) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4431) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4431) Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4431) Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: project version determines how package name is retrieved for a project (dir name vs. config's
projectNamefield)./kind bug
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs