*: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .'#4466
Merged
jmrodri merged 1 commit intooperator-framework:masterfrom Feb 4, 2021
Merged
*: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .'#4466jmrodri merged 1 commit intooperator-framework:masterfrom
jmrodri merged 1 commit intooperator-framework:masterfrom
Conversation
Member
Author
|
Supplants PR #4226 since that one has to be rebased again. |
jmrodri
force-pushed
the
reorder-docker-args
branch
2 times, most recently
from
c028640 to
66380c1
Compare
varshaprasad96
approved these changes
Feb 3, 2021
estroz
suggested changes
Feb 3, 2021
Because folks may have 'docker' aliased to 'podman', and Podman
prefers options before positional arguments:
$ podman build --help | grep CONTEXT-DIRECTORY
podman build [command options] CONTEXT-DIRECTORY | URL
We can't change the v2 sample since it still uses the old format.
Co-authored-by: W. Trevor King <wking@tremily.us>
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
jmrodri
force-pushed
the
reorder-docker-args
branch
from
66380c1 to
1220503
Compare
Member
|
/retest |
Member
Author
|
/retest |
jmrodri
added a commit
to jmrodri/operator-sdk
that referenced
this pull request
Feb 4, 2021
…rator-framework#4466)" This reverts commit 34e4a35. Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…amework#4466) Because folks may have 'docker' aliased to 'podman', and Podman prefers options before positional arguments: $ podman build --help | grep CONTEXT-DIRECTORY podman build [command options] CONTEXT-DIRECTORY | URL We can't change the v2 sample since it still uses the old format. Co-authored-by: W. Trevor King <wking@tremily.us> Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com> Co-authored-by: W. Trevor King <wking@tremily.us> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because folks may have
dockeraliased topodman, and Podman prefers options before positional arguments:Supersedes PR #4226
Co-authored-by: W. Trevor King wking@tremily.us
Signed-off-by: jesus m. rodriguez jmrodri@gmail.com
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs