upgrade cryptography sub-dependency#4525
upgrade cryptography sub-dependency#4525reinvantveer wants to merge 1 commit intooperator-framework:masterfrom
Conversation
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
|
@estroz It "just installed": https://github.com/operator-framework/operator-sdk/runs/1894851979?check_suite_focus=true#step:5:422. No installation of Rust compiler was needed. This is a bit puzzling, seeing #4510 (comment). I think this one requires a bit more investigation. |
|
I ran a quick smoke test by inserting a I admit I'm a little confused. Did v3.4.4 of cryptography get rewritten? |
|
Ah, now I see, this explains it: https://cryptography.io/en/latest/installation.html#building-cryptography-on-linux In our case, we just install a pre-built binary wheel, since we use an up-to-date pip! Edit: As the docs in the link above suggest, cryptography requires pip >=19.0 to install the pre-built wheel |
|
@reinvantveer: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@estroz Closing as this PR is unlikely to merge well with expected upcoming updates on the pipenv story |
Signed-off-by: Rein van 't Veer reinvantveer@gmail.com
This PR is part of #4237 to work towards a more user-friendly way of doing reproducible local builds
Description of the change:
Upgrade the
cryptographypackage in such a way that future updates can be installed.Motivation for the change:
The cryptography package saw some discussion recently when it switched to a toolchain that included a Rust compiler to install the package. This broke quite a few builds, also ones involving Ansible since it includes the cryptography package as a subdependency.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs