Use pipenv for python dependency management#4543
Use pipenv for python dependency management#4543estroz merged 2 commits intooperator-framework:masterfrom
Conversation
|
Needs to pass |
reinvantveer
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Hrm, it appears that I need some other image than registry.access.redhat.com/ubi8/ubi:8.3-227 to cross-build for s390x? Although https://travis-ci.com/github/operator-framework/operator-sdk/jobs/482845171#L235 doesn't seem to have much trouble using the same base image.
|
|
@estroz Did you get anywhere with the docker buildx method? I have a little trouble setting it up, some help would be greatly appreciated - then I can look into the hash diff mystery myself. |
|
@reinvantveer yeah take a look at #4554. Hoping to merge that this week. |
openshift-ci-robot
added
needs-rebase
reinvantveer
force-pushed
the
pipenv
branch
3 times, most recently
from
3e9891a to
aa9bb44
Compare
|
/rerun_tests (failed on link checker timeout untouched in PR) |
reinvantveer
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/rerun_tests |
|
@estroz This needs one of your magical /rerun_tests commands since I can't do that. Or I have to push dummy commits, which would be a waste. PR is failing on https://github.com/operator-framework/operator-sdk/pull/4543/checks?check_run_id=1998656554#step:4:115 where a link unrelated to this PR can't be polled. This test might work better if there would be some kind of retry mechanism in place. For the rest: tests are passing but I'm not quite sure whether the exotic architectures docker buildx tests were actually executed. |
|
/ok-to-test @reinvantveer you can do |
openshift-ci-robot
added
the
ok-to-test
|
/retest |
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
I got a working arm64 build locally, using: output: Details#1 [internal] load build definition from Dockerfile #1 sha256:81ff00aeac0ba31c0a2a78fc1200b798ab6760d9ba2fa4e6b60902d8402b4bc2 #1 transferring dockerfile: 32B done #1 DONE 0.0s#2 [internal] load .dockerignore #3 [internal] load metadata for registry.access.redhat.com/ubi8/ubi:8.3-227 #4 [1/8] FROM registry.access.redhat.com/ubi8/ubi:8.3-227@sha256:82e0fbbf1f3e223550aefbc28f44dc6b04967fe25788520eac910ac8281cec9e #6 [internal] load build context #4 [1/8] FROM registry.access.redhat.com/ubi8/ubi:8.3-227@sha256:82e0fbbf1f3e223550aefbc28f44dc6b04967fe25788520eac910ac8281cec9e #5 [2/8] RUN mkdir -p /etc/ansible && echo "localhost ansible_connection=local" > /etc/ansible/hosts && echo '[defaults]' > /etc/ansible/ansible.cfg && echo 'roles_path = /opt/ansible/roles' >> /etc/ansible/ansible.cfg && echo 'library = /usr/share/ansible/openshift' >> /etc/ansible/ansible.cfg #7 [3/8] COPY Pipfile* ./ #8 [4/8] RUN yum clean all && rm -rf /var/cache/yum/* && yum -y update && yum install -y libffi-devel openssl-devel python38-devel gcc python38-pip python38-setuptools && pip3 install pipenv==2020.11.15 && pipenv install --deploy && pipenv check && yum remove -y gcc libffi-devel openssl-devel python38-devel && yum clean all && rm -rf /var/cache/yum #9 [5/8] RUN echo "ansible:x:1001:0:ansible user:/opt/ansible:/sbin/nologin" >> /etc/passwd && mkdir -p /opt/ansible/.ansible/tmp && chown -R 1001:0 /opt/ansible && chmod -R ug+rwx /opt/ansible #10 [6/8] RUN TINIARCH=$(case #11 [7/8] WORKDIR /opt/ansible #12 [8/8] COPY bin/ansible-operator /usr/local/bin/ansible-operator #13 exporting to image |
|
Now #4554 has been merged I'm going to check if it runs other architecture tests for this PR as well |
|
@reinvantveer rebase with master and the image builds will run. |
retry of operator-framework#4538 and operator-framework#4494 Signed-off-by: reinvantveer <reinvantveer@gmail.com>
It ran! |
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
Can you add a changelog entry stating that openshift has been bumped to 0.11.2 and ansible-runner to 1.4.6? Otherwise LGTM!
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
3 participants
retry of #4538 and #4494
Signed-off-by: reinvantveer reinvantveer@gmail.com
Description of the change:
Retry of previous attempt on using Pipenv as dependency management solution for Ansible operator
Motivation for the change:
Previous build failed on missing gcc, which went unnoticed until checking the Travis builds on arm64, ppc64le, and s390x
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs