ci: add ansible-operator-base image and manual build workflow#4555
Merged
estroz merged 2 commits intooperator-framework:masterfrom Mar 4, 2021
Merged
ci: add ansible-operator-base image and manual build workflow#4555estroz merged 2 commits intooperator-framework:masterfrom
estroz merged 2 commits intooperator-framework:masterfrom
Conversation
Member
Author
|
/cc @jmrodri @theishshah |
Member
Author
|
The default tag would look like Which would then be pinned in # Builder
FROM --platform=$BUILDPLATFORM golang:1.15 as builder
ARG TARGETARCH
...
RUN GOOS=linux GOARCH=$TARGETARCH make build/ansible-operator
# New base image
FROM quay.io/operator-framework/ansible-operator-base:v1.4.0-24-g0c75f7af1801373a3c85e3fb728dd2dccfd6a851
COPY --from=builder /workspace/build/ansible-operator /usr/local/bin/ansible-operator
CMD ["/usr/local/bin/ansible-operator", "run", "--watches-file=./watches.yaml"] |
2 tasks
added 2 commits
March 3, 2021 12:21
ansible-operator-base image .github/workflows/deploy-manual.yml: start workflows manually, namely the ansible-operator-base image deployment job Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
735e749 to
b3fc889
Compare
Member
Author
|
/retest |
camilamacedo86
approved these changes
Mar 3, 2021
Contributor
camilamacedo86
left a comment
There was a problem hiding this comment.
I understand that we are only adding this one because it is required for we speeding the process to build the ansible image.
It is not required for helm because the only ansible one has many deps.
I am ok with 👍
varshaprasad96
approved these changes
Mar 4, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: the ansible-operator image takes awhile to build, so it would be nice to build a base image containing the long-running dependency installation steps every so often, ex. when dependencies are updated.
/area dependency
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs