update golang docs on CRD scoping#4812
Merged
estroz merged 2 commits intooperator-framework:masterfrom Apr 30, 2021
Merged
Conversation
| The CustomResourceDefinition (CRD) scope can also be changed for cluster-scoped operators so that there is only a single | ||
| instance (for a given name) of the Custom Resource (CR) to manage across the cluster. | ||
| Custom Resource Definitions (CRDs) contain a scope field that determines whether the resulting Custom Resource (CR) | ||
| is cluster or namespace scoped. Operators can be build making use of this feature that then operator either on the entire cluster, |
Contributor
There was a problem hiding this comment.
Operators can be built using this feature to ...
Contributor
Author
There was a problem hiding this comment.
wow, i don't know what happened there. thanks for the catch.
Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
estroz
suggested changes
Apr 26, 2021
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
A bunch of suggestions, the main themes being:
- To clarify that operator scope != CRD scope
- Go vs. non-Go configuration
Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the docs to discuss the various ways golang operators can control the scope of their CRD
Motivation for the change:
see issue #3684