cmd: add build subcommand#49
Merged
hongchaodeng merged 1 commit intooperator-framework:masterfrom Feb 23, 2018
hongchaodeng:build
Merged
cmd: add build subcommand#49hongchaodeng merged 1 commit intooperator-framework:masterfrom hongchaodeng:build
hongchaodeng merged 1 commit intooperator-framework:masterfrom
hongchaodeng:build
Conversation
fanminshi
reviewed
Feb 23, 2018
| This image will automatically set in the deployment manifests in output artifacts. | ||
|
|
||
| After build completes, the image would be built locally in docker. Then it needs to | ||
| be pushed to remote registry. For example: |
Contributor
There was a problem hiding this comment.
Maybe having For example: to start in a new line?
...
For example:
...
fanminshi
reviewed
Feb 23, 2018
| var buildCmd = &cobra.Command{ | ||
| Use: "build <image>", | ||
| Short: "Compiles code and builds artifacts", | ||
| Long: `The operator-sdk build command compiles the code and builds the artifacts |
Contributor
There was a problem hiding this comment.
Not sure how detail the command description needs to be. the termartifacts might need a bit more descriptions either here or some other doc.
Contributor
Author
There was a problem hiding this comment.
The artifacts in my mind is something produced in the software development process. It includes executables, documentation, deployment scripts, etc.
Let me think more about it if we want to say that right now.
Contributor
Author
|
I have made the description very explicit and clear so that it will give users a clear picture. |
Contributor
|
lgtm defer to @hasbro17 |
hasbro17
reviewed
Feb 23, 2018
| and generates Kubernetes manifests. | ||
|
|
||
| <image> is the container image to be built, e.g. "quay.io/example/operator:v0.0.1". | ||
| This image will automatically set in the deployment manifests. |
Contributor
|
LGTM after nit |
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
Fix paths in downstream dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.