Upgrade go 1.17#5497
Closed
ryantking wants to merge 1 commit intooperator-framework:masterfrom
Closed
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
ryantking
force-pushed
the
chore/gh5208_upgrade-go-1.17
branch
from
f5bee59 to
af7c88a
Compare
| GOBIN=$(LOCAL_BIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_GEN_VERSION) | ||
|
|
||
| KUSTOMIZE = $(shell pwd)/bin/kustomize | ||
| KUSTOMIZE = $(LOCAL_BIN)/kustomize |
Contributor
There was a problem hiding this comment.
Why update the goto 1.17 changed the Makefile layout and variables?
Why the Makefile here is the diff from kb: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v3/Makefile? We ought to only add to add on top what is required for the specific SDK helpers.
Also, from where came these changes? I could not find the boilerplate changed here.
/hold
openshift-ci
Bot
added
the
do-not-merge/hold
|
@ryantking: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
needs-rebase
Signed-off-by: Ryan King <ryking@redhat.com>
ryantking
force-pushed
the
chore/gh5208_upgrade-go-1.17
branch
from
af7c88a to
d782564
Compare
Contributor
Author
|
Handled by #5505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs