Add hybrid helm binary to operator-sdk#5504
Merged
varshaprasad96 merged 2 commits intooperator-framework:masterfrom Jan 24, 2022
Merged
Add hybrid helm binary to operator-sdk#5504varshaprasad96 merged 2 commits intooperator-framework:masterfrom
varshaprasad96 merged 2 commits intooperator-framework:masterfrom
Conversation
Member
Author
|
cc: @fabianvf |
varshaprasad96
added
the
do-not-merge/hold
Member
Author
|
This can go in only after SDK is bumped to use k8s 1.23, which happens here: #5503 |
openshift-ci
Bot
added
the
needs-rebase
varshaprasad96
force-pushed
the
add/hybrid-helm
branch
from
54b0e3e to
b1a242d
Compare
openshift-ci
Bot
removed
the
needs-rebase
varshaprasad96
removed
the
do-not-merge/hold
fabianvf
suggested changes
Jan 21, 2022
Member
Author
|
The PR has been tested and hybrid project works as expected. However, though the library is up-to-date, the scaffolding points towards a previous version. A new release of helm-operator-plugin is in process, and it can be updated in a follow up. |
This PR introduces a new binary to scaffold hybrid helm projects. For more details on what hybrid helm is, please refer: https://github.com/operator-framework/enhancements/blob/master/enhancements/hybrid-helm-operator.md For details on the hybrid plugin and the library, please refer: https://github.com/operator-framework/helm-operator-plugins Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
add/hybrid-helm
branch
from
b1a242d to
8ae9590
Compare
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
add/hybrid-helm
branch
from
0c3d088 to
4d6a0e7
Compare
fabianvf
approved these changes
Jan 24, 2022
Member
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
lgtm, go-e2e tests failed so I rekicked to see if it's just a flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add hybrid helm binary to operator-sdk
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs