Skip to content

fix java bump changelog in v1.18.0 docs#5614

Merged
jmrodri merged 1 commit intooperator-framework:masterfrom
jberkhahn:docs_typo
Apr 1, 2022
Merged

fix java bump changelog in v1.18.0 docs#5614
jmrodri merged 1 commit intooperator-framework:masterfrom
jberkhahn:docs_typo

Conversation

@jberkhahn
Copy link
Copy Markdown
Contributor

This wasn't actually a typo, seems @jmrodri forgot to fill in his changelog fragment?

fixes #5576

@jberkhahn
Copy link
Copy Markdown
Contributor Author

could @jmrodri take a look at this? the original PR is #5542 for reference

modified the Quarkus operator SDK version and tutorial too
chore: bump fabric8 5.8.0 & quarkus 2.4.0
modified the doc file and removed file after generation
release: fix release script to understand release branches
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not use here - as a prefix of all lines?

Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
@jmrodri
Copy link
Copy Markdown
Member

jmrodri commented Mar 27, 2022

So what is this trying to fix? I had a changelog for my v0.2.0 and my v0.3.0 bumps.

So what's working?

@jberkhahn
Copy link
Copy Markdown
Contributor Author

@jmrodri This PR is to fix the page in the upgrading-sdk docs, which is supposed to get populated from the changelog fragments, right? But currently there's a section that looks like changelog boilerplate where the bit from your PR is supposed to be.

Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@jmrodri jmrodri merged commit 324ca13 into operator-framework:master Apr 1, 2022
prary pushed a commit to prary/operator-sdk that referenced this pull request Apr 2, 2022
Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
Signed-off-by: Prashant Arya <prary2@gmail.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this pull request Apr 4, 2022
Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading v1.18.0 documentation minor issue

3 participants