commands/operator-sdk,pkg/generator: Fix project root function and rbac updates for Ansible Operator#565
Conversation
|
Hi @dymurray. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
shawn-hurley
left a comment
There was a problem hiding this comment.
We need this to fix a bug that was introduced with changes to the build command.
@hasbro17 @AlexNPavel PTAL
AlexNPavel
left a comment
There was a problem hiding this comment.
LGTM. We'll probably need to look at the controller-runtime refactor branch as well. That checks for the existence of ./cmd/manager/main.go (and the location of the dockerfiles changed)
|
Yeah for now let's just make sure the Ansible CLI works on the master branch. Moving the type ansible CLI changes over to the refactor branch shouldn't be too hard. |
This fixes a regression introduced in: #561
To determine if we are in the project root I've changed it to look for
tmp/build/Dockerfile.I also changed the rbac files to have Jinja templating for required differences in Ansible Operator RBAC. It sounds like the Jinja can go away when master is rebased on controller-runtime but I could be wrong on that.