-
Notifications
You must be signed in to change notification settings - Fork 1.8k
api: framework api to register user sync() func #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package framework | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ) | ||
|
|
||
| /* | ||
| 'framework' asks only the user business logic to handle resource events. | ||
| It hides all nitty-gritty of k8s controller loop. | ||
|
|
||
| An example: | ||
| ```main.go | ||
| func main() { | ||
| framework.RegisterSync( | ||
| SyncCallback{ | ||
| SyncFunc: syncEtcdCluster, | ||
| ResourceType: &etcdapi.EtcdCluster{}, | ||
| }, | ||
| ) | ||
| framework.Run(context.TODO()) | ||
| } | ||
|
|
||
| func syncEtcdCluster(obj runtime.Object, existed bool) error { | ||
| if !existed { | ||
| destroyEtcdCluster() | ||
| return nil | ||
| } | ||
| ec := obj.(*etcdapi.EtcdCluster) | ||
| reconcile(ec) | ||
| return nil | ||
| } | ||
| ``` | ||
| */ | ||
|
|
||
| // SyncCallback defines user business logic for when resource events are triggered. | ||
| type SyncCallback struct { | ||
| // SyncFunc defines the func to sync a resource event. | ||
| // 'obj' is the current state of the resource on the event. | ||
| // 'existed' indicates whether this object still exists. If not, its relevant resources | ||
| // should be destroyed. | ||
| SyncFunc func(obj runtime.Object, existed bool) error | ||
| // ResourceType is used to decide what resource to watch and sync events | ||
| // It is an instantiation of the resource object which will be used to decide type at runtime. | ||
| ResourceType runtime.Object | ||
| } | ||
|
|
||
| // RegisterSync registers the callbacks where user business logic is defined. | ||
| func RegisterSync(cbs ...SyncCallback) { | ||
| panic("TODO: unimplemented") | ||
| } | ||
|
|
||
| // Run is the main entry point. | ||
| func Run(ctx context.Context) error { | ||
| panic("TODO: unimplemented") | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we discussed offline, sync should not be per resource based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
What's your suggestion for users to define the resources they "care about"?
Maybe we can change
RegisterSync(SyncBallback, ResourceTypesToWatch...)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should generate a Sync function stub for users to fill in. Users do not need to register that func with us at all. User only need to tell the SDK what resources that are interested in. Probably call sdk.Watch(resourceX).