Skip to content
This repository was archived by the owner on Aug 12, 2024. It is now read-only.
This repository was archived by the owner on Aug 12, 2024. It is now read-only.

Add unit tests for the provisioners #622

@everettraven

Description

@everettraven

I noticed the Bundle and BundleDeployment provisioners under internal/provisioner don't have unit tests. We should implement some unit tests that are based on running the Reconcile() function for each provisioner. In the unit tests we could easily mock the Unpacker interface with something like:

var _ source.Unpacker = &MockSource{}

// MockSource is a utility for mocking out an Unpacker source
type MockSource struct {
	// result is the result that should be returned when MockSource.Unpack is called
	result *source.Result

	// shouldError determines whether or not the MockSource should return an error when MockSource.Unpack is called
	shouldError bool
}

func (ms *MockSource) Unpack(ctx context.Context, catalog *catalogdv1beta1.Catalog) (*source.Result, error) {
	if ms.shouldError {
		return nil, errors.New("mocksource error")
	}

	return ms.result, nil
}

We should also add unit tests to the plain, helm, and registry provisioners if they don't already have them.

The creation of this issue was inspired by operator-framework/catalogd#65 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions