This repository was archived by the owner on Aug 12, 2024. It is now read-only.
⚠ Remove pointer to BundleTemplate from spec#758
Merged
stevekuznetsov merged 1 commit intooperator-framework:mainfrom Nov 7, 2023
Merged
⚠ Remove pointer to BundleTemplate from spec#758stevekuznetsov merged 1 commit intooperator-framework:mainfrom
BundleTemplate from spec#758stevekuznetsov merged 1 commit intooperator-framework:mainfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 21.14% 21.14%
=======================================
Files 14 14
Lines 1069 1069
=======================================
Hits 226 226
Misses 795 795
Partials 48 48
☔ View full report in Codecov by Sentry. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
m1kola
changed the title
BundleTemplate from specBundleTemplate from spec
`Template` field in `BundleDeploymentSpec` seems to have unnecessary pointer as we expect to always populate this field. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
stevekuznetsov
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Templatefield inBundleDeploymentSpecseems to have unnecessary pointer as we expect to always populate this field.This is a follow up for operator-framework/operator-controller#499 (comment)