This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Makefile: avoid re-evaluating vars unnecessarily; other minor fixup#877
Merged
grokspawn merged 1 commit intooperator-framework:mainfrom May 7, 2024
Merged
Conversation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 37.27% 37.27%
=======================================
Files 9 9
Lines 845 845
=======================================
Hits 315 315
Misses 486 486
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Contributor
|
I'm still not 100% sold on replacing ?= statements with the likes of ifeq ($(origin IMAGE_REPO), undefined)
include .bingo/Variables.mk
IMAGE_REPO := quay.io/operator-framework/rukpak
endifsince according to gnu make these are equivalent. Any other behavior should be considered a bug in the tool. However, as with the related PRs there are lots of other improvements which tangibly improve make interactions, so I'm content to agree-to-disagree on this point. 😄 |
grokspawn
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #875