Close #266, Write tests for create and cancel order

accountant/accountant-core/pom.xml

@@ -49,5 +49,9 @@
             <artifactId>spring-tx</artifactId>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+        </dependency>
     </dependencies>
 </project>

api/api-ports/api-persister-postgres/pom.xml

@@ -1,67 +1,71 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>co.nilin.opex.api</groupId>
-        <artifactId>api</artifactId>
-        <version>1.0-SNAPSHOT</version>
-        <relativePath>../../pom.xml</relativePath>
-    </parent>
-
-    <groupId>co.nilin.opex.api.ports.postgres</groupId>
-    <artifactId>api-persister-postgres</artifactId>
-    <name>api-persister-postgres</name>
-    <description>Persist items of Opex api on Postgres</description>
-
-    <dependencies>
-        <dependency>
-            <groupId>org.jetbrains.kotlin</groupId>
-            <artifactId>kotlin-reflect</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>co.nilin.opex.api.core</groupId>
-            <artifactId>api-core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>co.nilin.opex.utility.error</groupId>
-            <artifactId>error-handler</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.springframework.boot</groupId>
-            <artifactId>spring-boot-starter-data-r2dbc</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.r2dbc</groupId>
-            <artifactId>r2dbc-postgresql</artifactId>
-            <scope>runtime</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.postgresql</groupId>
-            <artifactId>postgresql</artifactId>
-            <scope>runtime</scope>
-        </dependency>
-        <dependency>
-            <groupId>io.projectreactor.kotlin</groupId>
-            <artifactId>reactor-kotlin-extensions</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.jetbrains.kotlinx</groupId>
-            <artifactId>kotlinx-coroutines-reactor</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.jetbrains.kotlinx</groupId>
-            <artifactId>kotlinx-coroutines-core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>com.google.code.gson</groupId>
-            <artifactId>gson</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.projectreactor</groupId>
-            <artifactId>reactor-test</artifactId>
-            <scope>test</scope>
-        </dependency>
-    </dependencies>
-</project>
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>co.nilin.opex.api</groupId>
+        <artifactId>api</artifactId>
+        <version>1.0-SNAPSHOT</version>
+        <relativePath>../../pom.xml</relativePath>
+    </parent>
+
+    <groupId>co.nilin.opex.api.ports.postgres</groupId>
+    <artifactId>api-persister-postgres</artifactId>
+    <name>api-persister-postgres</name>
+    <description>Persist items of Opex api on Postgres</description>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.jetbrains.kotlin</groupId>
+            <artifactId>kotlin-reflect</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>co.nilin.opex.api.core</groupId>
+            <artifactId>api-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>co.nilin.opex.utility.error</groupId>
+            <artifactId>error-handler</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework.boot</groupId>
+            <artifactId>spring-boot-starter-data-r2dbc</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.r2dbc</groupId>
+            <artifactId>r2dbc-postgresql</artifactId>
+            <scope>runtime</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.postgresql</groupId>
+            <artifactId>postgresql</artifactId>
+            <scope>runtime</scope>
+        </dependency>
+        <dependency>
+            <groupId>io.projectreactor.kotlin</groupId>
+            <artifactId>reactor-kotlin-extensions</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jetbrains.kotlinx</groupId>
+            <artifactId>kotlinx-coroutines-reactor</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jetbrains.kotlinx</groupId>
+            <artifactId>kotlinx-coroutines-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>com.google.code.gson</groupId>
+            <artifactId>gson</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.projectreactor</groupId>
+            <artifactId>reactor-test</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito.kotlin</groupId>
+            <artifactId>mockito-kotlin</artifactId>
+        </dependency>
+    </dependencies>
+</project>

api/api-ports/api-persister-postgres/src/test/kotlin/co/nilin/opex/api/ports/postgres/impl/MarketQueryHandlerTest.kt

@@ -0,0 +1,151 @@
+package co.nilin.opex.api.ports.postgres.impl
+
+import co.nilin.opex.api.core.inout.OrderDirection
+import co.nilin.opex.api.core.inout.OrderStatus
+import co.nilin.opex.api.core.spi.SymbolMapper
+import co.nilin.opex.api.ports.postgres.dao.OrderRepository
+import co.nilin.opex.api.ports.postgres.dao.OrderStatusRepository
+import co.nilin.opex.api.ports.postgres.dao.TradeRepository
+import co.nilin.opex.api.ports.postgres.impl.sample.Valid
+import kotlinx.coroutines.flow.count
+import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.flow.flow
+import kotlinx.coroutines.runBlocking
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.Test
+import org.mockito.kotlin.*
+import reactor.core.publisher.Flux
+import reactor.core.publisher.Mono
+
+class MarketQueryHandlerTest {
+    private val orderRepository: OrderRepository = mock()
+    private val tradeRepository: TradeRepository = mock()
+    private val orderStatusRepository: OrderStatusRepository = mock()
+    private val symbolMapper: SymbolMapper = mock()
+    private val marketQueryHandler =
+        MarketQueryHandlerImpl(orderRepository, tradeRepository, orderStatusRepository, symbolMapper)
+
+    @Test
+    fun givenAggregatedOrderPrice_whenOpenASKOrders_thenReturnOrderBookResponseList(): Unit = runBlocking {
+        stubbing(orderRepository) {
+            on {
+                findBySymbolAndDirectionAndStatusSortAscendingByPrice(
+                    eq(Valid.ETH_USDT),
+                    eq(OrderDirection.ASK),
+                    eq(1),
+                    argThat {
+                        this == listOf(
+                            OrderStatus.NEW.code,
+                            OrderStatus.PARTIALLY_FILLED.code
+                        )
+                    }
+                )
+            } doReturn Flux.just(Valid.AGGREGATED_ORDER_PRICE_MODEL)
+        }
+
+        val orderBookResponses = marketQueryHandler.openAskOrders(Valid.ETH_USDT, 1)
+
+        assertThat(orderBookResponses).isNotNull
+        assertThat(orderBookResponses.size).isEqualTo(1)
+        assertThat(orderBookResponses.first()).isEqualTo(Valid.ORDER_BOOK_RESPONSE)
+    }
+
+    @Test
+    fun givenAggregatedOrderPrice_whenOpenBIDOrders_thenReturnOrderBookResponseList(): Unit = runBlocking {
+        stubbing(orderRepository) {
+            on {
+                findBySymbolAndDirectionAndStatusSortDescendingByPrice(
+                    eq(Valid.ETH_USDT),
+                    eq(OrderDirection.BID),
+                    eq(1),
+                    argThat {
+                        this == listOf(
+                            OrderStatus.NEW.code,
+                            OrderStatus.PARTIALLY_FILLED.code
+                        )
+                    }
+                )
+            } doReturn Flux.just(Valid.AGGREGATED_ORDER_PRICE_MODEL)
+        }
+
+        val orderBookResponses = marketQueryHandler.openBidOrders(Valid.ETH_USDT, 1)
+
+        assertThat(orderBookResponses).isNotNull
+        assertThat(orderBookResponses.size).isEqualTo(1)
+        assertThat(orderBookResponses.first()).isEqualTo(Valid.ORDER_BOOK_RESPONSE)
+    }
+
+    @Test
+    fun givenOrder_whenLastOrder_thenReturnQueryOrderResponse(): Unit = runBlocking {
+        stubbing(orderRepository) {
+            on {
+                findLastOrderBySymbol(Valid.ETH_USDT)
+            } doReturn Mono.just(Valid.MAKER_ORDER_MODEL)
+        }
+        stubbing(orderStatusRepository) {
+            on {
+                findMostRecentByOUID(Valid.MAKER_ORDER_MODEL.ouid)
+            } doReturn Mono.just(Valid.MAKER_ORDER_STATUS_MODEL)
+        }
+
+        val queryOrderResponse = marketQueryHandler.lastOrder(Valid.ETH_USDT)
+
+        assertThat(queryOrderResponse).isNotNull
+        assertThat(queryOrderResponse).isEqualTo(Valid.MAKER_QUERY_ORDER_RESPONSE)
+    }
+
+    @Test
+    fun givenOrderAndTradeAndSymbolAlias_whenLastPrice_thenPriceTickerResponse(): Unit = runBlocking {
+        stubbing(tradeRepository) {
+            on {
+                findAllGroupBySymbol()
+            } doReturn Flux.just(Valid.TRADE_MODEL)
+            on {
+                findBySymbolGroupBySymbol(Valid.ETH_USDT)
+            } doReturn Flux.just(Valid.TRADE_MODEL)
+        }
+        stubbing(orderRepository) {
+            on {
+                findByOuid(Valid.MAKER_ORDER_MODEL.ouid)
+            } doReturn Mono.just(Valid.MAKER_ORDER_MODEL)
+        }
+        stubbing(symbolMapper) {
+            onBlocking {
+                map(Valid.ETH_USDT)
+            } doReturn "ETHUSDT"
+        }
+
+        val priceTickerResponse = marketQueryHandler.lastPrice(Valid.ETH_USDT)
+
+        assertThat(priceTickerResponse).isNotNull
+        assertThat(priceTickerResponse.size).isEqualTo(1)
+        assertThat(priceTickerResponse.first().symbol).isEqualTo("ETHUSDT")
+        assertThat(priceTickerResponse.first().price).isEqualTo("100000.0")
+    }
+
+    @Test
+    fun givenOrderAndTrade_whenRecentTrades_thenMarketTradeResponseFlow(): Unit = runBlocking {
+        stubbing(tradeRepository) {
+            on {
+                findBySymbolSortDescendingByCreateDate(Valid.ETH_USDT, 1)
+            } doReturn flow {
+                emit(Valid.TRADE_MODEL)
+            }
+        }
+        stubbing(orderRepository) {
+            on {
+                findByOuid(Valid.TRADE_MODEL.makerOuid)
+            } doReturn Mono.just(Valid.MAKER_ORDER_MODEL)
+            on {
+                findByOuid(Valid.TRADE_MODEL.takerOuid)
+            } doReturn Mono.just(Valid.TAKER_ORDER_MODEL)
+        }
+
+        val marketTradeResponses = marketQueryHandler.recentTrades(Valid.ETH_USDT, 1)
+
+        assertThat(marketTradeResponses).isNotNull
+        assertThat(marketTradeResponses.count()).isEqualTo(1)
+        assertThat(marketTradeResponses.first()).isEqualTo(Valid.MARKET_TRADE_RESPONSE)
+    }
+}
+

api/api-ports/api-persister-postgres/src/test/kotlin/co/nilin/opex/api/ports/postgres/impl/OrderPersisterTest.kt

@@ -0,0 +1,46 @@
+package co.nilin.opex.api.ports.postgres.impl
+
+import co.nilin.opex.api.ports.postgres.dao.OrderRepository
+import co.nilin.opex.api.ports.postgres.dao.OrderStatusRepository
+import co.nilin.opex.api.ports.postgres.impl.sample.Valid
+import kotlinx.coroutines.runBlocking
+import org.assertj.core.api.Assertions.assertThatNoException
+import org.junit.jupiter.api.Test
+import org.mockito.kotlin.any
+import org.mockito.kotlin.doReturn
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.stubbing
+import reactor.core.publisher.Mono
+
+class OrderPersisterTest {
+    private val orderRepository: OrderRepository = mock()
+    private val orderStatusRepository: OrderStatusRepository = mock()
+    private val orderPersister = OrderPersisterImpl(orderRepository, orderStatusRepository)
+
+    @Test
+    fun givenOrderRepo_whenSaveRichOrder_thenSuccess(): Unit = runBlocking {
+        stubbing(orderRepository) {
+            on {
+                save(any())
+            } doReturn Mono.just(Valid.MAKER_ORDER_MODEL)
+        }
+        stubbing(orderStatusRepository) {
+            on {
+                save(any())
+            } doReturn Mono.just(Valid.MAKER_ORDER_STATUS_MODEL)
+        }
+
+        assertThatNoException().isThrownBy { runBlocking { orderPersister.save(Valid.RICH_ORDER) } }
+    }
+
+    @Test
+    fun givenOrderRepo_whenUpdateRichOrder_thenSuccess(): Unit = runBlocking {
+        stubbing(orderStatusRepository) {
+            on {
+                save(any())
+            } doReturn Mono.just(Valid.MAKER_ORDER_STATUS_MODEL)
+        }
+
+        assertThatNoException().isThrownBy { runBlocking { orderPersister.update(Valid.RICH_ORDER_UPDATE) } }
+    }
+}