Cleanup features #21338
Open
Cleanup features #21338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
cleanup-features
branch
2 times, most recently
from
707bde5 to
053d568
Compare
Contributor
Author
|
I am carefully ignoring Rubocop offenses. They all occur in code that I didn't touch except for deindenting it. |
Checking for the flag was removed already, but its definition was not yet removed.
This has been part of OpenProject for a few releases already and there is no need to disable it anymore.
The feature has been active without issues, so the toggle can be removed.
NobodysNightmare
force-pushed
the
cleanup-features
branch
from
053d568 to
9f289bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a bunch of unused feature flags. Lots of deindenting happened in specs. I suggest to view this PR with hiding whitespace changes.