Bug/73464 user cannot save their notifications preferences if they save the show versions folded boolean as no#22641
Merged
EinLama merged 10 commits intorelease/17.3from Apr 7, 2026
Conversation
…r-cannot-save-their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
…r-cannot-save-their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
Fixes rspec ./modules/costs/spec/features/time_entry_dialog_spec.rb:330 The reason it failed is that the id of the searched for work package might also be the id of the project or the status. Using the subject is stable
…their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
EinLama
approved these changes
Apr 7, 2026
Contributor
EinLama
left a comment
EinLama
left a comment
There was a problem hiding this comment.
Looks good and works 👍 I think we should merge the additional improvements as they are a simplification in one case - and removal of dead code in another case. It won't hurt to have them in knocking on wood.
EinLama
deleted the
bug/73464-user-cannot-save-their-notifications-preferences-if-they-save-the-show-versions-folded-boolean-as-no
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/73464
What are you trying to accomplish?
Started out as a fix for a missing value on an unchecked checkbox. That is done in fa2a07a.
Then, it also adapts the labels on said checkbox to reference sprints instead of versions (7149d3a).
Those are the two parts that need to be in for 17.3. The other two commits could also be split off into a branch to be merged into dev. 1f78f5a enforces the validation of user prefs by using the
UserPreferences::UpdateServiceinside theUsers::UpdateServicethe lack of this validation was the root cause for the original bug being unnoticed first. An invalid value (according to the schema) was saved in the database. By then saving the backlogs preferences same as the rest of the prefs, the code could be simplified.The last commit (0e2de3f) removes code dead for more than 10 years.
There is still a shortcoming in this solution. Faulty fields don't have an inline error:
This is still better than before where a faulty value was silently rejected. A success message was shown instead.