security/tailscale: Set auth key to optional in UI #5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Dec 5, 2025
fichtner
reviewed
Dec 5, 2025
security/tailscale/src/opnsense/mvc/app/models/OPNsense/Tailscale/Authentication.xml
Show resolved
Hide resolved
fichtner
reviewed
Dec 5, 2025
| <label>Pre-authentication Key</label> | ||
| <type>text</type> | ||
| <help>Use a non-reusable auth key and disable expiration</help> | ||
| <help>Use a non-reusable auth key and disable expiration (optional). If not specified use AuthURL from Status page</help> |
Member
There was a problem hiding this comment.
if you really want to bury it set it to advanced
Contributor
Author
There was a problem hiding this comment.
I wasn't sure on this, hiding it in advanced was my first thought. I do think it's right thing to do, but was thinking about what people are currently used to doing.
Member
There was a problem hiding this comment.
can also put this advanced flag on master only for 26.1 inclusion? so there is a bit more visibility for 2 more months
Contributor
Author
There was a problem hiding this comment.
That sounds like a good idea.
Contributor
Author
There was a problem hiding this comment.
That sounds like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the pre-authentication key as an optional field, will allow tailscale registration using either a pre-auth of key or the AuthURL obtained from the status page if enabled without the auth key.
Quality of life improvement to remove the need to create pre-auth keys manually first, users will still need to set the machine key to not expire after regristration in the tailscale dashboard