Skip to content

docs: update build performance benchmarks#112

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
benchmark/build-20260226-053328
Closed

docs: update build performance benchmarks#112
github-actions[bot] wants to merge 1 commit intomainfrom
benchmark/build-20260226-053328

Conversation

@github-actions
Copy link
Contributor

Automated build benchmark update from workflow run #53.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Automated benchmark update for version 2.4.0 with updated performance metrics.

Key changes:

  • Updated README.md benchmark table with latest performance numbers
  • Added v2.4.0 benchmark data to BUILD-BENCHMARKS.md (107 files, up from 99)
  • Native build speed: 2.1 ms/file (11% regression from 1.9 ms/file)
  • WASM build speed: 6.5 ms/file (slight improvement from 6.6 ms/file)

Issue found:

  • The automated script (scripts/update-benchmark-report.js) has a bug that removes the "Lightweight Footprint" section from README.md when updating benchmarks. The regex replacement on line 220 captures and replaces the entire Performance section including subsections, but the replacement text doesn't preserve them. This should be fixed to prevent unintended content removal in future updates.

Confidence Score: 2/5

  • This PR has a significant issue - it unintentionally removes documentation content
  • While the benchmark data updates are correct, the automated script has a bug that removes the "Lightweight Footprint" section from the README. This is unintended content loss that should be addressed before merging. The script needs to be fixed to preserve subsections within the Performance section.
  • README.md requires attention - the deleted "Lightweight Footprint" section should be restored

Important Files Changed

Filename Overview
README.md Updated build benchmarks, but automated script incorrectly removed the "Lightweight Footprint" section
generated/BUILD-BENCHMARKS.md Added version 2.4.0 benchmark data with updated metrics (107 files, performance regression noted)

Last reviewed commit: 7f43722

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 403 to 410

| Metric | Latest |
|---|---|
| Build speed (native) | **1.9 ms/file** |
| Build speed (WASM) | **6.6 ms/file** |
| Build speed (native) | **2.1 ms/file** |
| Build speed (WASM) | **6.5 ms/file** |
| Query time | **2ms** |
| ~50,000 files (est.) | **~95.0s build** |
| ~50,000 files (est.) | **~105.0s build** |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated benchmark script removed the "Lightweight Footprint" section that existed here. This is a bug in scripts/update-benchmark-report.js - the regex on line 220 matches the entire Performance section including subsections, but the replacement text doesn't preserve them. The script should either:

  1. Parse and preserve ### subsections within the Performance section
  2. Or use a more precise regex to only replace the benchmark table itself

The comment in the script (lines 218-219) says subsections "are preserved" but they're actually being deleted.

@carlos-alm
Copy link
Contributor

Closing: the benchmark updater regex had a bug that deleted the Lightweight Footprint README section. Fixed the regex and re-ran benchmarks on the latest code — both included in PR #117.

@carlos-alm carlos-alm closed this Feb 26, 2026
@carlos-alm carlos-alm deleted the benchmark/build-20260226-053328 branch February 26, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant