Skip to content

docs: update build performance benchmarks#122

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
benchmark/build-20260226-075105
Closed

docs: update build performance benchmarks#122
github-actions[bot] wants to merge 1 commit intomainfrom
benchmark/build-20260226-075105

Conversation

@github-actions
Copy link
Contributor

Automated build benchmark update from workflow run #57.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Automated benchmark update for v2.4.0 that adds new performance data to BUILD-BENCHMARKS.md and updates the Performance section in README.md.

Key changes:

  • Native build speed regressed from 1.9 to 2.2 ms/file (+16%)
  • WASM build improved slightly from 6.6 to 6.4 ms/file (-3%)
  • File count increased from 99 to 109 files
  • DB size per file increased from 3848 to 4397 bytes (+14%)

Critical issue:

  • The "Lightweight Footprint" subsection (h3) was unintentionally deleted from README.md. This is caused by a regex bug in scripts/update-benchmark-report.js:220 that captures h3 subsections when replacing the Performance section. The automation script needs to be fixed to preserve subsections.

Confidence Score: 2/5

  • Not safe to merge - unintended documentation removal
  • While the benchmark data was updated correctly, the PR unintentionally removed the "Lightweight Footprint" section from README.md due to a bug in the automation script, resulting in lost documentation content
  • README.md requires attention - the removed "Lightweight Footprint" section must be restored

Important Files Changed

Filename Overview
README.md Updated benchmark numbers (native build regressed 16%), but unintentionally removed "Lightweight Footprint" subsection
generated/BUILD-BENCHMARKS.md Added v2.4.0 benchmark data correctly with trend indicators

Last reviewed commit: cef12b1

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile


Optional: `@huggingface/transformers` (semantic search), `@modelcontextprotocol/sdk` (MCP server) — lazy-loaded only when needed.

## 🤖 AI Agent Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Lightweight Footprint" subsection (### heading with dependency table) was unintentionally removed. This is caused by a bug in scripts/update-benchmark-report.js line 220 — the regex /## 📊 Performance\r?\n[\s\S]*?(?=\r?\n## (?!#)|$)/ captures h3 subsections when replacing the Performance section.

The script should only replace the benchmark table, not the entire section including subsections.

@carlos-alm
Copy link
Contributor

Superseded by #121 which includes expanded benchmark format (incremental + query metrics).

@carlos-alm carlos-alm closed this Feb 26, 2026
@carlos-alm carlos-alm deleted the benchmark/build-20260226-075105 branch February 26, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant