Skip to content

docs: update 2.6.0 changelog with dogfood bug fixes#242

Merged
carlos-alm merged 9 commits intomainfrom
fix/dogfood-bugs-235-236-237
Mar 2, 2026
Merged

docs: update 2.6.0 changelog with dogfood bug fixes#242
carlos-alm merged 9 commits intomainfrom
fix/dogfood-bugs-235-236-237

Conversation

@carlos-alm
Copy link
Contributor

Summary

…ld docs

- Add node/edge count drift detection after incremental builds (>20% warns
  to use --no-incremental), persisting counts in build_meta
- Improve complexity command: when data is missing but graph exists, suggest
  --no-incremental instead of implying no graph exists
- Add @huggingface/transformers as devDependency so embedding benchmarks
  work out of the box
- Document dev build tarball installation in README (npm install <url> fails
  for optional platform deps)

Impact: 3 functions changed, 5 affected
…provements

Impact: 1 functions changed, 1 affected
- Add build.driftThreshold to config defaults (0.2) so the 20%
  incremental build drift threshold is user-configurable
- Include actual drift percentages and threshold in warning message
  for easier debugging
- Regenerate package-lock.json to include @huggingface/transformers
  devDependency (fixes License Compliance Scan CI failure)

Impact: 1 functions changed, 1 affected
…ative version

- filter directory nodes from reverse-deps query to prevent EISDIR (#235)
- load unchanged barrel files into reexportMap so barrel-resolved edges
  aren't dropped during incremental rebuilds (#236)
- add --strip flag to sync-native-versions.js removing platform
  optionalDependencies in dev builds, fixing npm install failures (#237)
- sync Cargo.toml version with package.json and automate via version script
- add barrel-project fixture and incremental-parity test

Impact: 4 functions changed, 1 affected
@claude
Copy link

claude bot commented Mar 2, 2026

Claude finished @carlos-alm's task —— View job


PR Review: docs: update 2.6.0 changelog with dogfood bug fixes

Todo List:

  • Phase 1: Root Cause Analysis - Understand problem being solved
  • Phase 2: Configuration Change Detection - Check for high-risk changes
  • Phase 3: Test Integrity - Verify no weakened assertions
  • Phase 4: Code Quality Review - Analyze implementation details
  • Provide final assessment and recommendation

Root Cause Analysis

Problem Being Solved: Updating 2.6.0 changelog to document bug fixes from PRs #233, #239, #240, #241 that were merged after initial changelog was written. These fixes address incremental build reliability issues.

Why This Approach: Legitimate documentation update for existing merged fixes. The actual bug fixes are already in the codebase - this PR just documents them properly in the changelog.

Risk Assessment: Low risk - primarily documentation changes with supporting test infrastructure.

Critical Concerns

None detected. This is a well-structured documentation update.

Code Quality Assessment ✅

Documentation Quality:

  • Changelog entries are specific and reference PR numbers ✅
  • Links to PRs instead of commit hashes (more maintainable) ✅
  • Clear descriptions of what each fix addresses ✅
  • Proper categorization (Bug Fixes, Testing sections) ✅

Supporting Code Changes (from previous commits):

  • Builder.js changes implement proper barrel file handling ✅
  • Logic prevents duplicate edge creation during incremental builds ✅
  • Clear comments explain why barrel files are loaded but not processed ✅
  • Test coverage added with comprehensive incremental parity verification ✅

Test Quality:

  • New incremental-parity test is thorough and well-designed ✅
  • Tests both node and edge consistency ✅
  • Proper isolation using temp directories ✅
  • Addresses specific barrel file edge case mentioned in bug reports ✅

Script Changes:

  • sync-native-versions.js adds --strip flag for dev builds ✅
  • Prevents npm install failures with dev versions ✅
  • Includes Cargo.toml version sync automation ✅

Final Recommendation

  • Rating: ⭐⭐⭐⭐ (4/5)
  • Action: APPROVE
  • Reasoning: High-quality documentation update with excellent supporting test coverage. The actual bug fixes were properly implemented in previous commits, and this PR correctly documents them. No configuration changes that weaken rules, no test integrity issues, and the code changes are well-reasoned and tested.

Minor Positives:

  • Uses PR links instead of commit hashes for better maintainability
  • Comprehensive test coverage for the barrel file edge case
  • Clear separation between documentation and implementation
  • Proper Git commit structure

No concerns identified - this is exactly how changelog updates should be done after merging related bug fixes.


@carlos-alm carlos-alm merged commit be5df2b into main Mar 2, 2026
20 checks passed
@carlos-alm carlos-alm deleted the fix/dogfood-bugs-235-236-237 branch March 2, 2026 11:35
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

This PR updates the 2.6.0 CHANGELOG with bug fix entries from previously merged PRs #233, #239, #240, and #241. The actual code changes shown in the diff are from those prior PRs and were already merged to main.

What changed:

  • Added 9 bug fix entries documenting incremental rebuild improvements (EISDIR fix, barrel file handling, drift detection)
  • Updated release summary to include "incremental build reliability" theme
  • Added new "Testing" section documenting the barrel-project fixture and incremental-parity test
  • All new entries correctly reference their source PRs with proper links

Important context:
Only CHANGELOG.md is modified in this PR (commit dd9b510). The other 14 files in the diff are from PRs #233, #239, #240, #241 which are already merged. The git diff range includes those commits because this branch was created after they were merged.

The changelog entries accurately describe the changes from the referenced PRs and follow the project's conventional commit format.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only change updating CHANGELOG.md with accurate entries for already-merged bug fixes. No code changes, no logic changes, no risk.
  • No files require special attention

Important Files Changed

Filename Overview
CHANGELOG.md Added 2.6.0 bug fix entries for PRs #233, #239, #240, #241 covering incremental rebuild fixes and added Testing section
src/builder.js From PR #241/#240: Added EISDIR fix, barrel file handling, drift detection with configurable threshold, and metadata tracking (no changes in this PR)
src/complexity.js From PR #240: Improved error messaging to distinguish between no graph vs no complexity data (no changes in this PR)
src/config.js From PR #240: Added driftThreshold default of 0.2 for incremental build verification (no changes in this PR)
scripts/sync-native-versions.js From PR #241: Added --strip flag and Cargo.toml version sync automation (no changes in this PR)
.github/workflows/publish.yml From PR #241: Added --strip flag to sync-native-versions.js call in dev build packaging (no changes in this PR)
crates/codegraph-core/Cargo.toml From PR #241: Updated version to 2.6.0 to match package.json (no changes in this PR)
package.json From PR #240: Moved @huggingface/transformers to devDependencies, removed @modelcontextprotocol/sdk (no changes in this PR)
README.md From PR #241: Added dev builds installation note explaining tarball installation requirements (no changes in this PR)
tests/integration/incremental-parity.test.js From PR #241: New test verifying incremental builds produce same nodes/edges as full builds using barrel-project fixture (no changes in this PR)

Last reviewed commit: dd9b510

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant