Skip to content

fix: resolve three build bugs (#287, #288, #289) #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 1 commit into from
Mar 3, 2026
Merged

fix: resolve three build bugs (#287, #288, #289) #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 48 additions & 11 deletions src/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ export function purgeFilesFromGraph(db, files, options = {}) {
}

export async function buildGraph(rootDir, opts = {}) {
rootDir = path.resolve(rootDir);
const dbPath = path.join(rootDir, '.codegraph', 'graph.db');
const db = openDb(dbPath);
initSchema(db);
Expand Down Expand Up @@ -521,6 +522,48 @@ export async function buildGraph(rootDir, opts = {}) {
}

if (!isFullBuild && parseChanges.length === 0 && removed.length === 0) {
// Check if optional analysis was requested but never computed
const needsCfg =
opts.cfg &&
(() => {
try {
return db.prepare('SELECT COUNT(*) as c FROM cfg_blocks').get().c === 0;
} catch {
return true;
}
})();
const needsDataflow =
opts.dataflow &&
(() => {
try {
return (
db
.prepare(
"SELECT COUNT(*) as c FROM edges WHERE kind IN ('flows_to','returns','mutates')",
)
.get().c === 0
);
} catch {
return true;
}
})();

if (needsCfg || needsDataflow) {
info('No file changes. Running pending analysis pass...');
const analysisSymbols = await parseFilesAuto(files, rootDir, engineOpts);
if (needsCfg) {
const { buildCFGData } = await import('./cfg.js');
await buildCFGData(db, analysisSymbols, rootDir, engineOpts);
}
if (needsDataflow) {
const { buildDataflowEdges } = await import('./dataflow.js');
await buildDataflowEdges(db, analysisSymbols, rootDir, engineOpts);
}
closeDb(db);
writeJournalHeader(rootDir, Date.now());
return;
}

// Still update metadata for self-healing even when no real changes
if (metadataUpdates.length > 0) {
try {
Expand Down Expand Up @@ -911,7 +954,6 @@ export async function buildGraph(rootDir, opts = {}) {

// Second pass: build edges
_t.edges0 = performance.now();
let edgeCount = 0;
const buildEdges = db.transaction(() => {
for (const [relPath, symbols] of fileSymbols) {
// Skip barrel-only files — loaded for resolution, edges already in DB
Expand All @@ -927,7 +969,6 @@ export async function buildGraph(rootDir, opts = {}) {
if (targetRow) {
const edgeKind = imp.reexport ? 'reexports' : imp.typeOnly ? 'imports-type' : 'imports';
insertEdge.run(fileNodeId, targetRow.id, edgeKind, 1.0, 0);
edgeCount++;

if (!imp.reexport && isBarrelFile(resolvedPath)) {
const resolvedSources = new Set();
Expand All @@ -949,7 +990,6 @@ export async function buildGraph(rootDir, opts = {}) {
0.9,
0,
);
edgeCount++;
}
}
}
Expand Down Expand Up @@ -1050,7 +1090,6 @@ export async function buildGraph(rootDir, opts = {}) {
seenCallEdges.add(edgeKey);
const confidence = computeConfidence(relPath, t.file, importedFrom);
insertEdge.run(caller.id, t.id, 'calls', confidence, isDynamic);
edgeCount++;
}
}

Expand All @@ -1073,7 +1112,6 @@ export async function buildGraph(rootDir, opts = {}) {
if (!seenCallEdges.has(recvKey)) {
seenCallEdges.add(recvKey);
insertEdge.run(caller.id, recvTarget.id, 'receiver', 0.7, 0);
edgeCount++;
}
}
}
Expand All @@ -1090,7 +1128,6 @@ export async function buildGraph(rootDir, opts = {}) {
if (sourceRow) {
for (const t of targetRows) {
insertEdge.run(sourceRow.id, t.id, 'extends', 1.0, 0);
edgeCount++;
}
}
}
Expand All @@ -1106,7 +1143,6 @@ export async function buildGraph(rootDir, opts = {}) {
if (sourceRow) {
for (const t of targetRows) {
insertEdge.run(sourceRow.id, t.id, 'implements', 1.0, 0);
edgeCount++;
}
}
}
Expand Down Expand Up @@ -1266,7 +1302,8 @@ export async function buildGraph(rootDir, opts = {}) {
}

const nodeCount = db.prepare('SELECT COUNT(*) as c FROM nodes').get().c;
info(`Graph built: ${nodeCount} nodes, ${edgeCount} edges`);
const actualEdgeCount = db.prepare('SELECT COUNT(*) as c FROM edges').get().c;
info(`Graph built: ${nodeCount} nodes, ${actualEdgeCount} edges`);
info(`Stored in ${dbPath}`);

// Verify incremental build didn't diverge significantly from previous counts
Expand All @@ -1278,11 +1315,11 @@ export async function buildGraph(rootDir, opts = {}) {
const prevE = Number(prevEdges);
if (prevN > 0) {
const nodeDrift = Math.abs(nodeCount - prevN) / prevN;
const edgeDrift = prevE > 0 ? Math.abs(edgeCount - prevE) / prevE : 0;
const edgeDrift = prevE > 0 ? Math.abs(actualEdgeCount - prevE) / prevE : 0;
const driftThreshold = config.build?.driftThreshold ?? 0.2;
if (nodeDrift > driftThreshold || edgeDrift > driftThreshold) {
warn(
`Incremental build diverged significantly from previous counts (nodes: ${prevN}→${nodeCount} [${(nodeDrift * 100).toFixed(1)}%], edges: ${prevE}→${edgeCount} [${(edgeDrift * 100).toFixed(1)}%], threshold: ${(driftThreshold * 100).toFixed(0)}%). Consider rebuilding with --no-incremental.`,
`Incremental build diverged significantly from previous counts (nodes: ${prevN}→${nodeCount} [${(nodeDrift * 100).toFixed(1)}%], edges: ${prevE}→${actualEdgeCount} [${(edgeDrift * 100).toFixed(1)}%], threshold: ${(driftThreshold * 100).toFixed(0)}%). Consider rebuilding with --no-incremental.`,
);
}
}
Expand Down Expand Up @@ -1313,7 +1350,7 @@ export async function buildGraph(rootDir, opts = {}) {
codegraph_version: CODEGRAPH_VERSION,
built_at: new Date().toISOString(),
node_count: nodeCount,
edge_count: edgeCount,
edge_count: actualEdgeCount,
});
} catch (err) {
warn(`Failed to write build metadata: ${err.message}`);
Expand Down
Loading