Skip to content

fix: bump native engine version to 3.0.0#310

Merged
carlos-alm merged 1 commit intomainfrom
fix/native-version-305
Mar 4, 2026
Merged

fix: bump native engine version to 3.0.0#310
carlos-alm merged 1 commit intomainfrom
fix/native-version-305

Conversation

@carlos-alm
Copy link
Contributor

Summary

  • Bumps crates/codegraph-core/Cargo.toml version from 2.6.0 to 3.0.0 to match package.json
  • Fixes codegraph info reporting stale native version and potential unnecessary full rebuilds from version mismatch detection in buildGraph()

Closes #305

Test plan

  • After native binary rebuild, verify codegraph info shows Native version: 3.0.0
  • Verify no version mismatch warning in codegraph build output

Cargo.toml was still at 2.6.0 after the v3.0.0 release, causing
codegraph info to report a stale native version and potentially
triggering unnecessary full rebuilds from version mismatch detection.
@claude
Copy link

claude bot commented Mar 4, 2026

Claude finished @carlos-alm's task —— View job


PR Review: Native Engine Version Bump

Reviewing this pull request following strict code review guidelines:

Todo List

  • Phase 1: Root cause analysis - understand version mismatch problem
  • Phase 2: Configuration change detection - assess risk level
  • Phase 3: Test integrity verification
  • Phase 4: Code quality review
  • Provide structured rating and final recommendation

Root Cause Analysis

Problem Being Solved: The Rust native engine's Cargo.toml version (2.6.0) is out of sync with the main package.json version (3.0.0). This causes:

  1. codegraph info to display incorrect "Native version: 2.6.0"
  2. Version mismatch warnings in build output
  3. Potential unnecessary full rebuilds due to version detection logic in buildGraph() (builder.js:167-175)

Why This Approach: Direct version synchronization is the correct fix. The builder.js code specifically checks prevVersion !== CODEGRAPH_VERSION and triggers full rebuilds when versions don't match. This is functional behavior, not cosmetic.

Risk Assessment: LOW RISK - This is a legitimate bug fix with minimal scope.

Critical Concerns

✅ NO CRITICAL ISSUES FOUND

Code Quality Assessment

  • Change Scope: Minimal and targeted - single line version bump from 2.6.0 to 3.0.0
  • Version Alignment: Correctly matches main package.json version (line 3)
  • Functional Impact: Fixes codegraph info output and eliminates false-positive version mismatch rebuilds
  • Test Strategy: Appropriate - verifies both codegraph info output and absence of mismatch warnings

Test Plan Evaluation

The proposed test plan is adequate:

  • ✅ Verifies codegraph info shows correct "Native version: 3.0.0"
  • ✅ Confirms no version mismatch warning in build output
  • ⚠️ Minor Gap: Could benefit from automated test coverage, but manual verification is sufficient for this simple change

Final Recommendation

  • Rating: ⭐⭐⭐⭐☆ (4/5)
  • Action: APPROVE
  • Reasoning: Straightforward bug fix with clear justification, minimal risk, and appropriate testing approach. The change directly addresses a functional issue in the codebase's dual-engine architecture.

Recommendation: Approve and merge. This is a well-scoped fix that resolves legitimate version reporting and rebuild detection issues.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 4, 2026

Greptile Summary

Bumped native Rust engine version from 2.6.0 to 3.0.0 in Cargo.toml to match the main package version in package.json. This fixes codegraph info reporting a stale version and prevents unnecessary full rebuilds triggered by version mismatch detection in buildGraph().

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • Single-line version string update with no logic changes, directly fixes reported version mismatch issue
  • No files require special attention

Important Files Changed

Filename Overview
crates/codegraph-core/Cargo.toml Version bumped from 2.6.0 to 3.0.0 to match package.json

Last reviewed commit: 303cee1

@carlos-alm carlos-alm merged commit 8b96f7c into main Mar 4, 2026
20 checks passed
@carlos-alm carlos-alm deleted the fix/native-version-305 branch March 4, 2026 02:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: native engine reports version 2.6.0 in codegraph v3.0.0

1 participant