Skip to content

fix: use CORE_SYMBOL_KINDS in flow matching #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 7 commits into from
Mar 9, 2026
Merged

fix: use CORE_SYMBOL_KINDS in flow matching #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27d6298
fix: use CORE_SYMBOL_KINDS in flow matching for interfaces/types/structs
carlos-alm Mar 9, 2026
85b5238
fix: guard against empty opts.kinds array in findMatchingNodes
carlos-alm Mar 9, 2026
06fb91b
style: remove unnecessary parens to satisfy Biome formatter
carlos-alm Mar 9, 2026
5e12131
Merge remote-tracking branch 'origin/main' into fix/flow-kind-regression
carlos-alm Mar 9, 2026
0ff85a3
chore: integrate origin/main into fix/flow-kind-regression
carlos-alm Mar 9, 2026
4d99ee9
Merge branch 'main' into fix/flow-kind-regression
carlos-alm Mar 9, 2026
638b1ef
Merge branch 'main' into fix/flow-kind-regression
carlos-alm Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import { openReadonlyOrFail } from './db.js';
import { paginateResult } from './paginate.js';
import { findMatchingNodes, kindIcon } from './queries.js';
import { CORE_SYMBOL_KINDS, findMatchingNodes, kindIcon } from './queries.js';
import { outputResult } from './result-formatter.js';
import { FRAMEWORK_ENTRY_PREFIXES } from './structure.js';
import { isTestFile } from './test-filter.js';
Expand Down Expand Up @@ -100,13 +100,15 @@ export function flowData(name, dbPath, opts = {}) {
const maxDepth = opts.depth || 10;
const noTests = opts.noTests || false;

// Phase 1: Direct LIKE match on full name
let matchNode = findMatchingNodes(db, name, opts)[0] ?? null;
// Phase 1: Direct LIKE match on full name (use all 10 core symbol kinds,
// not just FUNCTION_KINDS, so flow can trace from interfaces/types/structs/etc.)
const flowOpts = { ...opts, kinds: opts.kind ? [opts.kind] : CORE_SYMBOL_KINDS };
let matchNode = findMatchingNodes(db, name, flowOpts)[0] ?? null;

// Phase 2: Prefix-stripped matching — try adding framework prefixes
if (!matchNode) {
for (const prefix of FRAMEWORK_ENTRY_PREFIXES) {
matchNode = findMatchingNodes(db, `${prefix}${name}`, opts)[0] ?? null;
matchNode = findMatchingNodes(db, `${prefix}${name}`, flowOpts)[0] ?? null;
if (matchNode) break;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function resolveMethodViaHierarchy(db, methodName) {
* Scoring: exact=100, prefix=60, word-boundary=40, substring=10, plus fan-in tiebreaker.
*/
export function findMatchingNodes(db, name, opts = {}) {
const kinds = opts.kind ? [opts.kind] : FUNCTION_KINDS;
const kinds = opts.kind ? [opts.kind] : opts.kinds?.length ? opts.kinds : FUNCTION_KINDS;

const rows = findNodesWithFanIn(db, `%${name}%`, { kinds, file: opts.file });

Expand Down