fix: change default embedding model to nomic-v1.5#54
Conversation
Change benchmark trigger from release:published to workflow_run on Publish so the two workflows no longer race. Benchmark now starts only after Publish completes successfully.
Tested all 22 CLI commands against the codegraph repo itself. Found 4 bugs: structure "." filter, stale embeddings after rebuild, default embed model requires HF auth, cross-language false positive.
jina-code requires HuggingFace authentication (gated model), causing `codegraph embed` to crash for users without HF_TOKEN. nomic-v1.5 is public, same 768d dimensions, and improved quality with 8192 context.
|
Claude finished @carlos-alm's task —— View job Reviewing PR: Change Default Embedding Model to nomic-v1.5 ⭐⭐⭐⭐☆Todo List:
Root Cause Analysis ✅Problem Being Solved: The current default embedding model Why This Approach: Switching to
Risk Assessment: LOW - This is a sensible default change that fixes a real usability issue without breaking existing functionality. Configuration Change Detection ✅Examining all configuration changes: src/embedder.js:58 - ✅ DEFAULT_MODEL changed from 'jina-code' to 'nomic-v1.5' No concerning relaxations detected - All changes are consistent model updates, not rule/threshold relaxations. Test Integrity Verification ✅
Code Quality Review ✅
Critical ConcernsNone identified. This is a well-executed default change. Final Assessment |
Greptile SummaryChanged default embedding model from Changes include:
All changes are consistent and properly synchronized across code, tests, and documentation. The PR directly addresses a documented bug from dogfooding and improves the out-of-the-box user experience. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 3a88b4c |
Summary
jina-codetonomic-v1.5insrc/embedder.js,src/config.js,src/cli.js, andREADME.mdjina-codeis gated on HuggingFace and crashes withoutHF_TOKEN, makingcodegraph embedfail out-of-the-boxnomic-v1.5is public, same 768d dimensions, improved quality, 8192 token contextTest plan
codegraph modelsshows nomic-v1.5 as defaultcodegraph embed --helpshows nomic-v1.5 as default