Skip to content

perf: reduce WASM boundary crossings in JS extractor #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 1 commit into from
Feb 23, 2026
Merged

perf: reduce WASM boundary crossings in JS extractor #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/extractors/javascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,11 @@ export function extractSymbols(tree, _filePath) {
if (callInfo) {
calls.push(callInfo);
}
if (fn.type === 'member_expression') {
const cbDef = extractCallbackDefinition(node, fn);
if (cbDef) definitions.push(cbDef);
}
}
const cbDef = extractCallbackDefinition(node);
if (cbDef) definitions.push(cbDef);
break;
}

Expand Down Expand Up @@ -320,10 +322,6 @@ function extractReceiverName(objNode) {
if (objNode.type === 'identifier') return objNode.text;
if (objNode.type === 'this') return 'this';
if (objNode.type === 'super') return 'super';
if (objNode.type === 'member_expression') {
const prop = objNode.childForFieldName('property');
if (prop) return objNode.text;
}
return objNode.text;
}

Expand Down Expand Up @@ -432,8 +430,8 @@ const EXPRESS_METHODS = new Set([
]);
const EVENT_METHODS = new Set(['on', 'once', 'addEventListener', 'addListener']);

function extractCallbackDefinition(callNode) {
const fn = callNode.childForFieldName('function');
function extractCallbackDefinition(callNode, fn) {
if (!fn) fn = callNode.childForFieldName('function');
if (!fn || fn.type !== 'member_expression') return null;

const prop = fn.childForFieldName('property');
Expand Down
Loading