This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Update uncommitted changes check to apply on a spec by spec basis#1868
Merged
Update uncommitted changes check to apply on a spec by spec basis#1868
Conversation
nalanj
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍗 Description
What does this PR do? Anything folks should know?
Updates the uncommitted changes check to only look on a per spec basis. This also includes references as part of the definition if a path changed (we read this from the sourcemap)
We do this by storing the set of changes in the git diff (as an absolute path)
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
#1865
👹 QA
How can other humans verify that this PR is correct?