This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Support --generated and --upload for diff and diff-all#1883
Merged
Conversation
niclim
changed the title
--generated and --upload for diff and diff-all
niclim
commented
Apr 27, 2023
| tags, | ||
| orgId: specDetails.orgId, | ||
| }); | ||
| } else if (specs.from.context.vcs === VCS.Cloud) { |
Contributor
Author
There was a problem hiding this comment.
Fixes the upload flow when using --compare-from cloud:tag - since we'll set the spec id to whatever we downloaded from cloud
niclim
commented
Apr 27, 2023
| export async function getOrganizationFromToken( | ||
| client: OpticBackendClient, | ||
| message: string | ||
| message: string | false |
Contributor
Author
There was a problem hiding this comment.
Updates so that we can pass in false to just select the first org in certain cases (i.e. generated or CI)
nalanj
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍗 Description
What does this PR do? Anything folks should know?
Two changes:
--generatedflag to diff and diff-allTODO
--generated📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?