Set spectral rule result spec to after by niclim · Pull Request #2147 · opticdev/optic

niclim · 2023-07-20T17:12:26Z

🍗 Description

What does this PR do? Anything folks should know?

I think this will actually fix #2135

What's happening is that:

we run spectral rules and we specify that the rule failure is from the before spec - which is incorrect as it should be from the after spec
when we try to group this rule into the relevant node, it cannot be associated with the right tree and fails to find where it should go
because of this, it doesn't render

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

How can other humans verify that this PR is correct?

Set spectral rule result spec to after

c7eef0d

niclim requested a review from acunniffe July 20, 2023 17:12

acunniffe approved these changes Jul 20, 2023

View reviewed changes

niclim added this pull request to the merge queue Jul 21, 2023

Merged via the queue into main with commit dfc79c6 Jul 21, 2023

niclim deleted the fix/spectral-rules branch July 21, 2023 13:56