-
Notifications
You must be signed in to change notification settings - Fork 18
Support changing the range and fixing the value of VaryingParameters
#150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…-org/optimas into feature/fixed_parameters
for more information, see https://pre-commit.ci
VaryingParametersVaryingParameters
MaxThevenet
approved these changes
Dec 1, 2023
Collaborator
MaxThevenet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for interactive explorations where the range of varying parameters can be updated, or their values fixed. For example:
Currently, only the generators based on the Ax service API support updating the parameters. Support for other generators will be added in future PRs.
In order to support VaryingParameters with a fixed value, a set of
fixed_featuresneeds to be passed to Ax. This, however, is not currently possible with the Service API (unless facebook/Ax#2015 or something similar is merged). Therefore, this PR defines aCustomAxClientderived class that modifiesget_next_trialto supportfixed_features.Other changes
CustomAxClientrequiresAx>=0.3.4(and thereforepython>=3.9), which means that this PR also drops support for older Ax versions and Python 3.8.AxClients has been simplified. Now the subclasses of theAxServiceGeneratoronly need to define the list ofGenerationSteps, instead of creating anAxClient. This avoids code duplication.