Run generator on manager #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…rg/optimas into feature/gen_on_manager
jlnav
approved these changes
Apr 22, 2024
…libE_opt into feature/gen_on_manager
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new
"gen_on_manager"option from libEnsemble, allowing the generator to run in the same process as the manager. This avoids passing the generator to the worker as a copy, so that the generator thatgen_fuses is the same instance that was created by the user. This simplifies the code (no need to update the gen in a dirty way after the exploration run) and avoids potentially unexpected behavior that could result from operating on copies of the generator.Additionally, a new test has been added to check that GPU resource allocation works properly.