[FSSDK-8707] feat(metrics): Adds support for prometheus #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasirfolio3
changed the title
russell-loube-optimizely
changed the title
![prisma-cloud-devsecops[bot]](https://avatars.githubusercontent.com/in/135857?s=60&v=4){kind=small}
Mat001
requested changes
Jun 5, 2023
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
Looks good. Not an expert on Prometheus. A few license year comments
Mat001
requested changes
Jun 5, 2023
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
Looks good. Not an expert on Prometheus. A few license year comments
Mat001
approved these changes
Jun 5, 2023
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
I think it looks good now
pulak-opti
added a commit
that referenced
this pull request
Nov 2, 2023
* Added support for prometheus. * Added unit tests. * Added unit tests. * updated headers. * fixes. * cleanup. * Adding support for labels in prometheus and expvar. * Refactor code * fix readme * Fix copyright year --------- Co-authored-by: Mirza Sohail Hussain <mirza.sohailhussain@gmail.com> Co-authored-by: Pulak Bhowmick <pulak.bhowmick@episerver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OPTIMIZELY_ADMIN_METRICSTYPEenv variable can be used to switch betweenexpvarandprometheus. Default value isexpvar.Tests