[FSSDK-9705] feat: add OpenTelemetry tracing #400
Conversation
pulak-opti
changed the title
mikechu-optimizely
left a comment
mikechu-optimizely
left a comment
There was a problem hiding this comment.
Mostly just questions 👇 but otherwise LGTM...though probably should also get @jaeopt 's review.
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! A few suggestions and clarifications.
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
All looks good! A nit suggested.
I still see the "tracing" instead of "opentelemetry: tracing" in the config.yml.
Wondering about the plan.
ah sorry, config changes are fall behind for distributed tracing. btw I am still thinking what the config should be. |
pulak-opti
force-pushed
the
pulak/otel-tracing
branch
from
13d341c to
51cc0f9
Compare
* add a basic tracing pipeline * add tracing config * update tracing config * use context * update handler with middleware * support both http & grpc protocal * refactor config * add unit test * update unit test * refactor code * make tracing disabled by default * add config doc * fix typo * collect more attributes * add common http attributes * collect http status code attribute * collect sdk key attribute * support distributed tracing * add unit test for trace id generator * update unit test * fix typo * fix typo in config file * update config.yaml * make trace_id configurable for distributed tracing
Summary
Ticket