Skip to content

(fix): Corrupt datafile cache fix #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomaszurkan-optimizely merged 3 commits into from
Jul 11, 2019
Merged

(fix): Corrupt datafile cache fix #280

thomaszurkan-optimizely merged 3 commits into from
Jul 11, 2019

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jul 11, 2019 •
edited
Loading

Summary

  • If the cached datafile is removed or corrupted, and last modified has already been set, the app won't load.
  • If loading synchronously there is a similar problem where the datafile cache exists but is corrupt, it will also fail to initialize.

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely changed the title Corrupt datafile cache fix (fix): Corrupt datafile cache fix Jul 11, 2019
mikeproeng37
mikeproeng37 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

datafile-handler/src/main/java/com/optimizely/ab/android/datafile_handler/DatafileLoader.java Outdated
if (!datafileCache.exists() || (datafileCache.exists() && datafileCache.load() == null)) {
// create a wrapper for application context default storage.
OptlyStorage storage = new OptlyStorage(this.datafileService.getApplicationContext());
// set the last modified for this url to 1 millisecond passed Jan 1, 1970.
Copy link
Contributor

@mikeproeng37 mikeproeng37 Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think it's "past" and not "passed"

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit a7265a7 into master Jul 11, 2019
@mikeproeng37 mikeproeng37 deleted the corruptDatafileCacheFix branch July 12, 2019 18:33
@mikeproeng37 mikeproeng37 mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomaszurkan-optimizely @mikeproeng37