Skip to content

Conversation

@juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Jul 22, 2019

Summary

Updates version of jackson-databind to pass SourceClear vulnerability scanning.

androidTestImplementation "com.noveogroup.android:android-logger:$android_logger_ver"
androidTestImplementation "com.google.code.gson:gson:$gson_ver"
androidTestImplementation "com.fasterxml.jackson.core:jackson-databind:2.9.8"
androidTestImplementation "com.fasterxml.jackson.core:jackson-databind:$jacksonversion"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if i can actually do this

@juancarlostong
Copy link
Contributor Author

in the build logs i get:

/home/travis/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-databind/2.9.9.1/211dfab27bdd15a569247fee4690a07a177044f8/jackson-databind-2.9.9.1.jar: D8: Type `org.w3c.dom.bootstrap.DOMImplementationRegistry` was not found, it is required for default or static interface methods desugaring of `void com.fasterxml.jackson.databind.ext.DOMSerializer.<init>()`

but that message was already there previously. see here

Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancarlostong juancarlostong changed the title fix(jackson-databind): update version fix(jackson-databind): update version (pr to master) Jul 23, 2019
@juancarlostong
Copy link
Contributor Author

ill cherry pick these in via commits in 3.1.x branch later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants