Skip to content

fix: change eventDispatcherInterval units for consistency #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaeopt merged 6 commits into from
May 27, 2020
Merged

fix: change eventDispatcherInterval units for consistency #323

jaeopt merged 6 commits into from
May 27, 2020

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Mar 9, 2020 •
edited
Loading

Summary

  • Inconsistencies in using eventDispatcherInterval units (millisecs and secs). Fix all to be consistent.
  • Change eventDispatcherInterval from millisecs to secs to be consistent with datafileDownloadInterval in secs.

Issues

  • JIRA-6027

@jaeopt jaeopt requested a review from a team as a code owner March 9, 2020 22:41
@jaeopt jaeopt added the chore label Apr 6, 2020
@jaeopt jaeopt removed the chore label May 12, 2020
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 1ce6fcf into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaeopt @thomaszurkan-optimizely