Skip to content

Fix: Reverted putting namespace in gradle file instead of manifiest #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaeopt merged 2 commits into from
Nov 21, 2022
Merged

Fix: Reverted putting namespace in gradle file instead of manifiest #438

jaeopt merged 2 commits into from
Nov 21, 2022

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Nov 21, 2022 •
edited by jaeopt
Loading

Summary

  • Reverted putting namespace in gradle file instead of manifiest (see PR 437)

Issues

  • FSSDK-8688

@mnoman09 mnoman09 changed the base branch from master to jae/upgrade November 21, 2022 14:05
@mnoman09 mnoman09 changed the title Mnoman/upgrade test Fix: Reverted putting namespace in gradle file instead of manifiest Nov 21, 2022
jaeopt
jaeopt approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt marked this pull request as ready for review November 21, 2022 17:16
@jaeopt jaeopt requested a review from a team as a code owner November 21, 2022 17:16
@jaeopt jaeopt merged commit 36b6984 into jae/upgrade Nov 21, 2022
@jaeopt jaeopt deleted the mnoman/upgradeTest branch November 21, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mnoman09 @jaeopt @NomanShoaib