feat(eventdispatcher): HttpClientEventDispatcher45 now logs full exception#112
feat(eventdispatcher): HttpClientEventDispatcher45 now logs full exception#112mikeproeng37 merged 7 commits intomasterfrom
Conversation
mfahadahmed
changed the title
mfahadahmed
changed the title
|
|
||
| namespace OptimizelySDK.Utils | ||
| { | ||
| public static class ExtensionMethods |
There was a problem hiding this comment.
This seems like a very generic name. Can we call it ExceptionExtensionMethods?
This is actually a pretty cool feature of the platform/language btw.
There was a problem hiding this comment.
@mikeng13 I believe the name should be ExceptionDetailExtension, since it's class, looks odd to call with Methods? make sense?
There was a problem hiding this comment.
further need to make it internal, since this can't be used outside DLL.
There was a problem hiding this comment.
Renamed the class as ExceptionExtensions to contain any exception related extensions in it, as the name ExceptionDetailExtension looks too specific. Thoughts?
There was a problem hiding this comment.
Also making the class internal restricts us from using it directly in unit tests. Please let me know if that approach needs to be changed.
|
|
||
| namespace OptimizelySDK.Utils | ||
| { | ||
| public static class ExceptionExtensions |
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm, please update the header years
| @@ -0,0 +1,34 @@ | |||
| /* | |||
| * Copyright 2018, Optimizely | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2017, Optimizely | |||
| * Copyright 2017-2018, Optimizely | |||
3 participants
No description provided.