Skip to content

fix(set-forced-variation): Treats empty variation key as invalid and does not reset variation. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikeproeng37 merged 1 commit into from
Nov 13, 2018
Merged

fix(set-forced-variation): Treats empty variation key as invalid and does not reset variation. #113

mikeproeng37 merged 1 commit into from
Nov 13, 2018

Conversation

@mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Nov 13, 2018 •
edited
Loading

Summary

  • Forced variation key passed as an empty String will be considered as invalid.
  • Updated unit tests for empty string variation key.

mikeproeng37
mikeproeng37 approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 4fd7abf into master Nov 13, 2018
@oakbani oakbani deleted the fahad/invalid-forced-variation-key branch November 14, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfahadahmed @mikeproeng37