fix(eventtagsutils) : don't exclude falsy values#132
Merged
mikeproeng37 merged 2 commits intomasterfrom Jan 28, 2019
Merged
Conversation
mikeproeng37
approved these changes
Jan 26, 2019
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm, just have some small suggestions
| } | ||
|
|
||
| [Test] | ||
| public void TestConversionEventWithFalsyValues() |
Contributor
There was a problem hiding this comment.
nit: with falsy numeric and revenue values
| } | ||
|
|
||
| [Test] | ||
| public void TestConversionEventWithNumericValue1() |
Contributor
There was a problem hiding this comment.
nit: maybe we should check revenue and event value in separate tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0 and 1 after deserialization converted into long and we were not considering long in the numeric method. just added it. Along with I realized to add short/uint as well.
The "why", or other context.
Test plan
Issues