Conversation
Contributor
Author
|
|
Contributor
|
nitpick: you should also change it here: https://github.com/optimizely/csharp-sdk/pull/109/files#diff-bf67f3e7c1b4668fffb73733c1c3ebfaR22 |
juancarlostong
force-pushed
the
jctong/versioning
branch
from
9007442 to
34ab9df
Compare
mikeproeng37
approved these changes
Mar 1, 2019
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Looks good, I just have a few nits
updating version in other helper scripts
juancarlostong
force-pushed
the
jctong/versioning
branch
from
ba058bc to
dd57630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remaining versioning changes to complete https://optimizely.atlassian.net/browse/OASIS-4088