Skip to content

feat(api): Feature variable APIs now return default variable value when featureEnabled property is false. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 3 commits into from
Apr 1, 2019
Merged

feat(api): Feature variable APIs now return default variable value when featureEnabled property is false. #151

aliabbasrizvi merged 3 commits into from
Apr 1, 2019

Conversation

@mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Mar 26, 2019

Summary

  • Feature variable APIs now return default variable value when featureEnabled property is false.

Test plan

  • Added unit tests.

@msohailhussain msohailhussain requested review from a team and aliabbasrizvi March 27, 2019 20:29
@aliabbasrizvi aliabbasrizvi merged commit e17424f into master Apr 1, 2019
@aliabbasrizvi aliabbasrizvi deleted the fahad/feature-enabled-checking branch April 1, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

1 more reviewer

@mjc1283 mjc1283 mjc1283 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfahadahmed @mjc1283 @aliabbasrizvi