feat(dfm): Datafile management implementation by msohailhussain · Pull Request #160 · optimizely/csharp-sdk

msohailhussain · 2019-05-29T23:00:48Z

Summary

All details are in the doc.

Test plan

Issues

"THING-1234" or "Fixes refac(ci): improve build time #123"

…tConfigManager.

…rojectConfig as its implementation. Created StaticProjectConfigManager and HttpProjectConfigManager for handling datafile retrievel. Created PollingProjectConfigManager for retrieving ProjectConfig on the specified interval. Added OnReady future in PollingProjectConfigManager class. Added unit tests.

…esolves.

# Conflicts: # OptimizelySDK/DatafileManagement/DatafileProjectConfig.cs

…n designing DFM.

mikeproeng37 · 2019-05-30T21:34:37Z

OptimizelySDK/DatafileManagement/AtomicProjectConfigManager.cs

+
+namespace OptimizelySDK.DatafileManagement
+{
+    public class AtomicProjectConfigManager : ProjectConfigManager


There isn't anything about this class that makes it atomic. If that is the case, can we change the name to something else or actually make it atomic?

mikeproeng37 · 2019-05-30T23:22:18Z

OptimizelySDK/DatafileManagement/HttpProjectConfigManager.cs

+            //t.Start();
+            //return t;
+        }
+        static ProjectConfig ParseProjectConfig(string datafile)


I don't think this is the right place to put it. If you look at the Java SDK, the notion of a ProjectConfig backed by a Datafile is split from this and is defined at a higher level: https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java

The idea is that we can have other types of Datafile-backed project config that don't necessarily have to be polled, such as push-based with websockets or server-sent events.

mikeproeng37 · 2019-05-30T23:24:47Z

OptimizelySDK/DatafileManagement/ProjectConfig.cs

+
+namespace OptimizelySDK
+{
+    public interface ProjectConfig


ProjectConfig can be more abstract than this. We can have project configs later on that are not based on datafile, but can be based on a different structure. Here is the abstraction approach we took in the Java SDK:

https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/config/ProjectConfig.java

For this reason, also, we should change the name of the package to ProjectConfig instead of DatafileManagement so we don't tie it to just the Datafile transport type.

mjc1283 · 2019-06-03T23:06:41Z

OptimizelySDK/Config/DatafileProjectConfig.cs

+        /// set by the user by calling setForcedVariation (it is not the same as the
+        /// whitelisting forcedVariations data structure in the Experiments class).
+        /// </summary>
+        private Dictionary<string, Dictionary<string, string>> _ForcedVariationMap;


I'd suggest moving the forced variation state to the decision service, as we've done in other SDKs.

It's been moved in sohail/optimizelydfm (Will add PR today)

mikeproeng37

Mostly good. There are a few nits and we also need to move the forced variation logic into the decision service. A good way to do that would be to open up another PR against sohail/dfmcomplete with that change. We can review and merge and then rebase this PR for merging.

mikeproeng37 · 2019-06-04T17:21:26Z

OptimizelySDK/Config/DatafileProjectConfig.cs

@@ -0,0 +1,643 @@
+/* 
+ * Copyright 2017-2019, Optimizely


nit: Should just be 2019

mikeproeng37 · 2019-06-04T17:21:48Z

OptimizelySDK/Config/DatafileProjectConfig.cs

+        /// set by the user by calling setForcedVariation (it is not the same as the
+        /// whitelisting forcedVariations data structure in the Experiments class).
+        /// </summary>
+        private Dictionary<string, Dictionary<string, string>> _ForcedVariationMap;


mikeproeng37 · 2019-06-04T17:22:12Z

OptimizelySDK/Config/DatafileProjectConfig.cs

+        private Dictionary<string, List<string>> ExperimentFeatureMap = new Dictionary<string, List<string>>();
+
+
+        //========================= Callbacks ===========================


nit: These aren't really callbacks are they?

mikeproeng37 · 2019-06-04T17:23:43Z

OptimizelySDK/Config/FallbackProjectConfigManager.cs

+
+namespace OptimizelySDK.Config
+{
+    public class FallbackProjectConfigManager : ProjectConfigManager


Is there gonna be more logic for the "fallback"? I think you mentioned you'd have that in a separate PR. In that case just add a //TODO here for it

nope, no more logic, in other PR, I will remov SetConfig, and ProjectConfig will only be set by constructor.

mikeproeng37 · 2019-06-04T17:23:58Z

OptimizelySDK/Config/HttpProjectConfigManager.cs

+        public Task OnReady()
+        {
+            return CompletableConfigManager.Task;
+            //Task t = new Task(() => {


nit: remove

mikeproeng37

lgtm. We just need to remove the ForcedVariationMap from the DatafileProjectConfig

msohailhussain · 2019-06-04T22:36:05Z

lgtm. We just need to remove the ForcedVariationMap from the DatafileProjectConfig

I removed in this PR.
https://github.com/optimizely/csharp-sdk/pull/161/files#diff-6c7503ba59bde21387a0424b504ad19dL137

msohailhussain and others added 18 commits April 9, 2019 11:47

Initial structure

5cbd740

cleanup

f6487ae

added builder class

e385a95

Extracted ProjectConfig into its own interface and updated HttpProjec…

4eb4104

…tConfigManager.

Added polling unit tests.

33cc9fa

Working on Config manager.

16729e9

Removed old ProjectConfig references.

904072e

Merge remote-tracking branch 'origin/master' into sohail/dfm

9586f2c

Fixed missing file references.

cadf4ee

Update ConfigManager classes to block execution until ProjectConfig r…

f49e833

…esolves.

Added config manager unit tests and fix failing tests.

6189f26

Updated fm

5f9a371

Added unit tests and AtomicProjectConfigManager class.

e287ee7

Adding unit tests.

74a2833

unit test added and 4.0 compat.

1d6b3d6

Resolved compatible issues.

44d94c4

Merge branch 'master' into sohail/dfm

2b220b0

# Conflicts: # OptimizelySDK/DatafileManagement/DatafileProjectConfig.cs

msohailhussain closed this May 29, 2019

msohailhussain reopened this May 30, 2019

msohailhussain added 3 commits May 30, 2019 12:54

Removed DFM implementation in Optimizely from this PR. Mainly focus o…

dc20812

…n designing DFM.

Resolved datafile management namespace issue.

a285f1e

Datafilemore cleanup

72869c7

msohailhussain requested review from aliabbasrizvi, mikeproeng37 and mjc1283 May 30, 2019 22:45

mikeproeng37 suggested changes May 30, 2019

View reviewed changes

msohailhussain added 3 commits May 31, 2019 11:22

Moved ProjectConfig file

7f209a2

renamed to fallback project config manager

99e7a11

Remover parse and added logger and error handler

0c51253

msohailhussain requested review from mikecdavis and mikeproeng37 May 31, 2019 19:06

Changed namespace & removed SetConfig from interface.

249b201

mjc1283 reviewed Jun 4, 2019

View reviewed changes

mikeproeng37 suggested changes Jun 4, 2019

View reviewed changes

msohailhussain added 3 commits June 4, 2019 12:11

comments addressed.

6297b83

matt’s feedback added.

80a4014

Nit fix

aaac4e8

msohailhussain requested a review from mikeproeng37 June 4, 2019 22:10

mikeproeng37 reviewed Jun 4, 2019

View reviewed changes

msohailhussain changed the title ~~ci(feat): Datafile management implementation~~ feat(dfm): Datafile management implementation Jun 4, 2019

mikeproeng37 approved these changes Jun 6, 2019

View reviewed changes

mikeproeng37 merged commit ccc6bd2 into sohail/dfmcomplete Jun 7, 2019

msohailhussain deleted the sohail/dfm branch September 24, 2019 17:48

		private Dictionary<string, List<string>> ExperimentFeatureMap = new Dictionary<string, List<string>>();


		//========================= Callbacks ===========================

Conversation

msohailhussain commented May 29, 2019

Summary

Test plan

Issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeproeng37 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeproeng37 left a comment

Choose a reason for hiding this comment

Uh oh!

msohailhussain commented Jun 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants