Move forced variations into DecisionService.#162
Merged
mikeproeng37 merged 2 commits intosohail/optimizelydfmfrom Jun 14, 2019
Merged
Move forced variations into DecisionService.#162mikeproeng37 merged 2 commits intosohail/optimizelydfmfrom
mikeproeng37 merged 2 commits intosohail/optimizelydfmfrom
Conversation
msohailhussain
added a commit
that referenced
this pull request
Jun 17, 2019
* Initial structure * cleanup * added builder class * Extracted ProjectConfig into its own interface and updated HttpProjectConfigManager. * Added polling unit tests. * Working on Config manager. * Extacted ProjectConfig into a separate interface and create DatafileProjectConfig as its implementation. Created StaticProjectConfigManager and HttpProjectConfigManager for handling datafile retrievel. Created PollingProjectConfigManager for retrieving ProjectConfig on the specified interval. Added OnReady future in PollingProjectConfigManager class. Added unit tests. * Removed old ProjectConfig references. * Fixed missing file references. * Update ConfigManager classes to block execution until ProjectConfig resolves. * Added config manager unit tests and fix failing tests. * Updated fm * Added unit tests and AtomicProjectConfigManager class. * Adding unit tests. * unit test added and 4.0 compat. * Resolved compatible issues. * Removed DFM implementation in Optimizely from this PR. Mainly focus on designing DFM. * optimizely changes. * Resolved datafile management namespace issue. * Datafilemore cleanup * integrated projectconfigmanagez * Moved ProjectConfig file * renamed to fallback project config manager * Remover parse and added logger and error handler * Changed namespace & removed SetConfig from interface. * Added config in all methods. * rename issues resolved. * Integrating dfm with optimizely * comments addressed. * matt’s feedback added. * Nit fix * added optimizelyfactory and get variation private method to use config. * corrected condition * Added missing documentation. * Move forced variation back to ProjectConfig. * refac(decisions): Move forced variations into DecisionService. (#162) * Revert "refac(decisions): Move forced variations into DecisionService. (#162)" (#164) This reverts commit 6441b00. * consolidated mike’s feedback * Resolved one left comment. * Logging issue fixed and fallback issue fixed. * Changed IsValid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan