Skip to content

feature variable type enum removed #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pawels-optimizely merged 2 commits into from
Apr 14, 2020
Merged

feature variable type enum removed #211

pawels-optimizely merged 2 commits into from
Apr 14, 2020

Conversation

@msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Apr 14, 2020

Summary

  • FeatureVariableType enum removed.
  • Using constant values for Type which are string
  • Type variable is now string type in FeatureVariable.

Test plan

  • Added unit tests which will make sure that additional types shouldn't have any breaking change.
  • E2E should pass without modifying any code.

Issues

  • FeatureVariableType and GetFeatureVariableType were public, users who are using these undocumented type may have issues if they upgrade SDK.

@msohailhussain msohailhussain requested a review from a team as a code owner April 14, 2020 20:19
pawels-optimizely
pawels-optimizely reviewed Apr 14, 2020
View reviewed changes
pawels-optimizely
pawels-optimizely approved these changes Apr 14, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawels-optimizely pawels-optimizely merged commit b7df60f into master Apr 14, 2020
@pawels-optimizely pawels-optimizely deleted the sohail/removefvenum branch April 14, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@msohailhussain msohailhussain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msohailhussain @pawels-optimizely